UninterpretedConstOracle refactor
#2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2734 +/- ##
==========================================
+ Coverage 78.82% 78.85% +0.03%
==========================================
Files 464 465 +1
Lines 15879 15895 +16
Branches 2589 2590 +1
==========================================
+ Hits 12516 12534 +18
+ Misses 3363 3361 -2
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thpani
approved these changes
Oct 19, 2023
| import org.scalatestplus.scalacheck.Checkers | ||
|
|
||
| @RunWith(classOf[JUnitRunner]) | ||
| class TestUCOracle extends AnyFunSuite with BeforeAndAfterEach with Checkers { |
There was a problem hiding this comment.
Shortening the class name makes this hard to find (if I'm looking for the tests for UninterpretedConstOracle).
Suggested change
| class TestUCOracle extends AnyFunSuite with BeforeAndAfterEach with Checkers { | |
| class TestUninterpretedConstOracle extends AnyFunSuite with BeforeAndAfterEach with Checkers { |
There was a problem hiding this comment.
Good point. I'll have to add this manually though to also rename the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionalityFollowing the pattern laid out in #2709 for
IntOracle, this PR introduces the same alterations toUninterpretedConstOracle.